TL;DR: I think you got it right.

Most places would want to use state6502, because most places have always used that and the processor emulation didn't always support breakpoints that could trigger prior to an instruction running to completion. But you're doing something special.

debug_state6502 is the "debug copy" of the cpu's state made prior to executing the current operation, so that the CPU can return itself to that state in the event that an instruction halts mid-way due to a breakpoint. Since you're in the middle of an instruction, you probably want to refer to that debug copy since most folks won't easily be able to interpret a debug message that indicates a PC register that isn't aligned with the instruction, or worse, possibly points to the next instruction being executed. Lord knows I've certainly gotten confused by that in the past.